From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 4 Aug 2016 22:45:39 +0000 (-0700)
Subject: resourceloader: Add missing @private and @protected to mw.loader methods
X-Git-Tag: 1.31.0-rc.0~6163^2
X-Git-Url: http://git.cyclocoop.org/%7D%7Cconcat%7B?a=commitdiff_plain;h=46719f112c0d17c8768ab02109fb0f9013008b5f;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Add missing @private and @protected to mw.loader methods

Several local functions were indexed by JSDuck as mw.loader methods whereas
they are in fact they don't even exist on that object. Mark them as @private.

Also add @protected on the internal methods 'work()' and 'require()',
which are public but not for general use (and may change without warning).

Change-Id: If521cc5ae4a565a46161890cf32e95a8c7f4ca50
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 3600000a70..ef4f6df12e 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -903,6 +903,7 @@
 			 * The CSS will be appended to an existing ResourceLoader-created `<style>` tag
 			 * or create a new one based on whether the given `cssText` is safe for extension.
 			 *
+			 * @private
 			 * @param {string} [cssText=cssBuffer] If called without cssText,
 			 *  the internal buffer will be inserted instead.
 			 * @param {Function} [callback]
@@ -981,7 +982,7 @@
 			}
 
 			/**
-			 * @since 1.26
+			 * @private
 			 * @param {Array} modules List of module names
 			 * @return {string} Hash of concatenated version hashes.
 			 */
@@ -1544,6 +1545,7 @@
 			 * size of the startup module. This function changes those dependency lists back to
 			 * arrays of strings.
 			 *
+			 * @private
 			 * @param {Array} modules Modules array
 			 */
 			function resolveIndexedDependencies( modules ) {
@@ -1576,6 +1578,8 @@
 
 				/**
 				 * Batch-request queued dependencies from the server.
+				 *
+				 * @protected
 				 */
 				work: function () {
 					var	reqBase, splits, maxQueryLength, q, b, bSource, bGroup, bSourceGroup,
@@ -2056,8 +2060,9 @@
 				/**
 				 * Get the exported value of a module.
 				 *
-				 * Module provide this value via their local `module.exports`.
+				 * Modules may provide this via their local `module.exports`.
 				 *
+				 * @protected
 				 * @since 1.27
 				 * @return {Array}
 				 */